mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
575 stars 209 forks source link

fix(functional-tests): Improve specificity of settings heading locator #17181

Closed vpomerleau closed 1 week ago

vpomerleau commented 1 week ago

Because

This pull request

Issue that this pull request solves

Closes: #FXA-9991

Checklist

Put an x in the boxes that apply

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

vpomerleau commented 1 week ago

Agree we can iterate on this, but at least we should avoid false positives moving forwards.

pdehaan commented 1 week ago

"I don't have a suggestion for a better locator, the settings page doesn't have something super distinct to hook on to."

Should we add something better to hook on to in the front end? Like, if we could change the front end to pass in custom data-testid="" values via <AppLayout> or something if we're trying to assert we're on a specific page?

Trinaa commented 1 week ago

@pdehaan we've been trying to move away from test IDs and implementation in locators if possible, but you are right that in some cases this might be the better solution.