fix(admin): handle no invoice error - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

575 stars 209 forks source link

fix(admin): handle no invoice error #17183

Closed StaberindeZA closed 6 days ago

StaberindeZA commented 1 week ago

Because

Admin panel rejects with an error if it can't find a Stripe invoice.
Stripe typically does not allow invoice deletion, and therefore this error is usually only seen on Stage after Stripe cleans up test data.

This pull request

Catches the error on invoice failure, and if its due to missing invoice, log the error, and assume customer subscription data is stale, and simply return void.

Issue that this pull request solves

Closes: #FXA-9051

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[x] I have added necessary documentation (if appropriate).
[x] I have verified that my changes render correctly in RTL (if appropriate).