fix(functional-tests): Await confirmation of totp setup in tests - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

575 stars 209 forks source link

fix(functional-tests): Await confirmation of totp setup in tests #17185

Closed vpomerleau closed 1 week ago

vpomerleau commented 1 week ago

Because

We were not await confirmation that totp was enabled before signing out of settings in tests
This could cause a race condition where totp setup was incomplete before sign out, causing flakiness in tests

This pull request

Add assertion for totp enabled after forms are filled out

Issue that this pull request solves

Closes: #FXA-10001

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

LZoog commented 1 week ago

I'm going to go ahead and merge this since it's been r+'d and Valerie's on PTO through next week, and more stable tests are always nice.