mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
575 stars 209 forks source link

feat(metrics): set metrics flow data via data attrs #17192

Closed chenba closed 6 days ago

chenba commented 1 week ago

Because:

This commit:

chenba commented 1 week ago

@chenba In my local testing the flowId from Backbone app (email first) -> React app (signup) is not maintained. I wonder if it makes sense to make the flowId in query params the source of truth since we currently set that when coming from content-server.

The flow id and begin time in the query params should have higher precedence. That's by default but I also pass the flowQueryParam into the init to make that explicit. If you look at the requests, which flow id do you see in the payload?

chenba commented 1 week ago

Is it alot of work to set this value from the url query params in the body element?

Probably not? I have not considered it. What's the advantage of doing so?