fix(paypal-processor): use initSentry helper - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

575 stars 209 forks source link

fix(paypal-processor): use initSentry helper #17193

Closed StaberindeZA closed 5 days ago

StaberindeZA commented 1 week ago

Because

Sentry errors logged by the paypal processor did not include additional error information.

This pull request

Update paypal processor script to use initSentry, which includes additional Sentry integrations, such as ExtraErrorData.
Replace deprecated ExtraErrorData integration with Sentry.extraErrorDataIntegration()

Issue that this pull request solves

Closes: #FXA-9219

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[x] I have added necessary documentation (if appropriate).
[x] I have verified that my changes render correctly in RTL (if appropriate).

StaberindeZA commented 5 days ago

Looks good, though will the packages/fxa-shared/sentry/node import work?

Yup it should. Stuff in auth-server regularly imports things from fxa-shared. I also quickly tested it locally, the way it'd be executed in stage/prod, and it seemed to run as expected.