mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
575 stars 209 forks source link

fix(sync): Send fxaCanLinkAccount in force_auth signin submit #17198

Closed LZoog closed 5 days ago

LZoog commented 6 days ago

Because:

This commit:

fixes FXA-9868


Our functional tests for force auth covers this case, but I can add a couple of unit tests if we want.

Maybe there's a better way to test this but I launched fxa-dev-launcher, then console.logged the test credentials and URL for these Sync desktop v3 force auth tests, ran one (yarn test --grep="sync v3 with a registered email, registered uid" --debug) and copied the URL output into the window dev-launcher opened and added showReactApp=true to it.

I saw when running these tests in Backbone this is where we were sending the message (on submit). So long as you answer OK, even if the PW is incorrect we don't re-prompt.

LZoog commented 5 days ago

@vbudhram Thanks for testing! I removed that console log, I'll go ahead and merge since that was the only change and CI was green, and I want to rebase Valerie's PR on this before the tag.