fix(auth): Set state when navigating with third party auth in React - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

fix(auth): Set state when navigating with third party auth in React #17207

Closed vbudhram closed 1 month ago

vbudhram commented 1 month ago

Because

Third party auth fails when logging in with a different email than one already logged in (React)

This pull request

Sets the state param when lauching auth so that it logs in correct user

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-10046

Checklist

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

Testing steps

Be enrolled in React signin experiment
Log in with a user ( ex a@aa.com)
Sign out
Log in with Google user

vbudhram commented 1 month ago

For some reason the linting task is failing because docker is running out of memory? I've ran the linter locally and all pass. Will retry linting but I think its ok to merge when approved.