feat(glean): Add account_pref_recovery_key_submit event - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

feat(glean): Add account_pref_recovery_key_submit event #17211

Closed vpomerleau closed 1 month ago

vpomerleau commented 1 month ago

Because

We want to track clicks to start an account recovery key setup flow

This pull request

Add glean event and emit in the appropriate settings page

Issue that this pull request solves

Closes: #FXA-10039

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[ ] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

This event is emitted when clicking on either 'Create' or 'Change' from the account recovery key row in Settings.

vpomerleau commented 1 month ago

Thanks for the review, much appreciated! The failing test is flaky and unrelated, I've hit re-run.