fix(sync): Adjust conditions for sending can_link_account on signin

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

fix(sync): Adjust conditions for sending can_link_account on signin #17214

Closed LZoog closed 1 month ago

LZoog commented 1 month ago

Because:

In the 'account disconnected' Sync state, users are now taken to /signin instead of /force_auth, so our logic needed to be updated

This commit:

Adjusts the logic for when we send the message. Only send if the user didn't first hit content-server (we will know based on a temporary query param until email-first is converted to React). The browser decides when to automatically respond with ok: true or prompt the user
Displays an error message when the user cancels

closes FXA-10176

LZoog commented 1 month ago

@LZoog I've tested this locally and we do get prompted with the merge dialog. However, I'm running into an issue where the user does not actually get logged in after confirming. It might be something with my local configs, going to r+ here to not block the tags. Screen.Recording.2024-07-26.at.3.12.11.PM.mov

Every time I try this, I'm prompted for code and I am logged in properly. I'd be surprised if this didn't work and normal sync sign in without dialog worked though? I'll test on stage and leave a note for QA.