bug(settings): Make sure event handler is attached before message is sent - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

bug(settings): Make sure event handler is attached before message is sent #17215

Closed dschom closed 1 month ago

dschom commented 1 month ago

Because:

On android mobile this response for 'CanLinkAccount' comes back immediately and no pop up is displayed.
As result, we potentially have a result, and the eventHandler might not be bound.

This pull request

Attach the event handler before sending the message.

Issue that this pull request solves

Closes: FXA-10057

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[ ] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

This is a bit tricky test on mobile at the moment. Final validation is needed on staging.