fix(metrics): DENG-3273 Update event names for consistency between `accounts-events` and `events` pings - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

fix(metrics): DENG-3273 Update event names for consistency between `accounts-events` and `events` pings #17218

Closed chenba closed 1 month ago

chenba commented 1 month ago

Because

We want event names in accounts-events ping to be consistent with event metric categories and names in events ping

This pull request

Updates recently added event names for consistency

Issue that this pull request solves

Closes: issue described in https://mozilla-hub.atlassian.net/browse/DENG-3273?focusedCommentId=907454

Checklist

Put an x in the boxes that apply

[ ] My commit is GPG signed.
[ ] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

chenba commented 1 month ago

@vpomerleau I've renamed and moved the third party auth reg/login start events. Can you take a quick look? Thanks.