Bug(settings): Fix for 'stuck' sign in button p2 - Githubissues

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)

https://mozilla.github.io/ecosystem-platform/

Mozilla Public License 2.0

589 stars 212 forks source link

Bug(settings): Fix for 'stuck' sign in button p2 #17219

Closed dschom closed 1 month ago

dschom commented 1 month ago

Because

When signing into sync on Android, the signin button can become 'stuck'
Yesterday we uncovered a race condition that seemed to help, but didn't totally fix the problem.
The event handler in fxaCanLinkAccount was too general and could pick up events that were not intended for it.

This pull request

Uses this.addEventListener(FirefoxCommand.CanLinkAccount instead of window.addEventListener('WebChannelMessageToContent'...
Doing so ensures that only responses for the CanLinkAccount command are handled.

Issue that this pull request solves

Closes: FXA-10057

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[ ] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

Note, we should avoid using window.addEventListener('WebChannelMessageToContent'

dschom commented 1 month ago

@LZoog Let's land and then you can rebase #17214?