mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
589 stars 212 forks source link

fix(metrics): DENG-3273 Update third_party_auth login event names for consistency between accounts-events and events pings #17226

Closed akkomar closed 1 month ago

akkomar commented 1 month ago

Because

This pull request

Issue that this pull request solves

Closes: Closes: issue similar to described in https://mozilla-hub.atlassian.net/browse/DENG-3273?focusedCommentId=907454

Checklist

Put an x in the boxes that apply

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

vpomerleau commented 1 month ago

Should all the event names for google/apple in the taxonomy sheet be updated to included third_party_auth?

chenba commented 1 month ago

@akkomar I don't think we need this PR anymore?

akkomar commented 1 month ago

@akkomar I don't think we need this PR anymore?

Yes, this doesn't seem to be needed anymore.