mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
589 stars 212 forks source link

feat(metrics): integrate Glean into content server backend #17231

Closed chenba closed 1 month ago

chenba commented 1 month ago

Because:

This commit

Also note that the server_events.js in this patch was generated with a patched version of glean_parser (https://github.com/mozilla/glean_parser/pull/726) so if you re-generate with yarn glean-generate, you'd end up with ESM and things will break.

vpomerleau commented 1 month ago

What's the alternative to running yarn glean-generate, if it will break things?

chenba commented 1 month ago

What's the alternative to running yarn glean-generate, if it will break things?

That's temporary. I don't think this needs to be blocked by a glean.js release. If you want to try generating that file, the CommonJS patch has landed in the main branch of glean_parser.

Actually this reminded me that I need to update glean-generate in package.json. Thanks!