fix(storybook): Fix fxa settings storybooks

vpomerleau commented 1 month ago

Because

Some storybooks were broken and impacted cross-functional collab

This pull request

Fixes storybooks for:
- images
- BrandMessaging
- ConnectedServices
- Signin
- SigninRecoveryCode
- Signup
Remove ThirdPartyAuthCallback story - the component is not currently used in React and was causing an inception storybook (storybook in storybook) that was taking too long to troubleshoot

Issue that this pull request solves

Closes: #FXA-10085

Checklist

Put an x in the boxes that apply

[x] My commit is GPG signed.
[x] If applicable, I have modified or added tests which pass locally.
[ ] I have added necessary documentation (if appropriate).
[ ] I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Storybooks for ResetPassword/AccountRecoveryConfirmKey and ResetPassword/AccountRecoveryResetPassword are still broken and not included in this patch.

LZoog commented 1 month ago

On closer inspection we probably want a follow up issue filed to look at our signin stories at least:

Shouldn’t pocket have other links showing?
Should we have a similar state^ for Monitor?
“Sign in to pocket with cached credentials” and “with password” are the same. If it's intentional because Pocket always needs the password, fine, but it's not super clear
Not sure if we want to tweak the "No Password" in "No Linked Account And No Password wording", that sounds confusing, but shows "Cached Credentials"
Are the Sync/third party auth states correct? "Sign In To Sync With Cached Credentials" could emphasize that a password is still asked for when the user has cached credentials and a sync login, but should third party auth buttons be shown?