Closed data-sync-user closed 4 years ago
➤ Dave Justice commented:
This would be great, [~bchen@mozilla.com] you are more familiar with the actual filter code, would you mind sizing this one?
➤ John Gruen commented:
This, to me is the most important outstanding remaining work on surveys
➤ Dave Justice commented:
I was thinking through this and it seems that we should complete 2095 and 2096 first,
The current implementation states that all of the conditions need to be met in order to show the survey, so passed results would be the same as config. Once we update https://jira.mozilla.com/browse/FXA-2095 and https://jira.mozilla.com/browse/FXA-2096, we would actually have some variability in the results and it would make sense to return the filtered results instead of just pass the config conditions along to the url.
Does this sound correct [~bchen@mozilla.com]?
➤ Barry Chen commented:
Mostly true. The only exception is the languages condition, where, for example, "en" will match "en" or any en-* languages.
➤ Barry Chen commented:
[~jgruen@mozilla.com] for subset matches like subscriptions, do you want the complete set of values or the subset from the survey's conditions? For example, if the condition is subscription plans [b, c] but the user is subscribed to [a, b, c, p, q], do you want [b, c] passed to the survey, or do you want to know what the user's subscribed to?
➤ John Gruen commented:
a,b,c,p,q
Currently we check the configured conditions during the filtering phase to determine eligibility, but we don't surface the matched values. We could pass these values into the survey as query params.
┆Issue is synchronized with this Jira Task ┆Issue Number: FXA-2094