search

mozilla / fxa

Monorepo for Mozilla Accounts (formerly Firefox Accounts)
https://mozilla.github.io/ecosystem-platform/
Mozilla Public License 2.0
589 stars 212 forks source link

[settings][l10n] Pull reused strings into App ftl file #7344

Closed data-sync-user closed 3 years ago

data-sync-user commented 3 years ago

Instead of duplicating strings across new-settings, let's collect them in one spot. The top-level App component's ftl file seems like a fine place. This will minimize the workload on our volunteer localizers.

┆Issue is synchronized with this Jira Task ┆Issue Number: FXA-2943

data-sync-user commented 3 years ago

➤ Barry Chen commented:

Fluent messages can reference each other (https://www.projectfluent.org/fluent/guide/references.html) ( https://www.projectfluent.org/fluent/guide/references.html) ) so we could DRY up repeated strings as well (e.g. "Firefox Accounts").

data-sync-user commented 3 years ago

➤ Barry Chen commented:

The error message for VerifiedSessionGuard is definitely repeated.  Maybe the component should provide a default.