Tweaks to Reviewer Dashboard table

mozilla / galaxy

To infinity and beyond. The front-end UI.

BSD 3-Clause "New" or "Revised" License

9 stars 14 forks source link

Tweaks to Reviewer Dashboard table #123

Closed cvan closed 10 years ago

cvan commented 10 years ago

Issue #15 was to add the basic UI for reviewing (i.e., approving/rejecting) games.

The status drop-down menu is being taken care of by issue #121. The buttons are being taken care of by issue #122.

Per the mocks, we need to make the following adjustments:

game icon (game.icons[0].src; should link to game detail page)
game title (should also link to game detail page; use the same anchor)
date submitted (we already have waiting time; just put that in parentheses next to date submitted if the game is still pending; this should always be shown regardless of which status we are viewing by)
date approved/rejected/disabled/deleted (if we are viewing by status approved/rejected/disabled/deleted, but not rejected)

aricha commented 10 years ago

date approved/rejected/disabled/deleted (if we are viewing by status approved/rejected/disabled/deleted, but not rejected)

Should we be keeping track of the entire history of status changes, then? I would think we'd only need to show the date of the last status change event, but if we might need some kind of status history then it'd be worth taking that into account in how that data is stored in the DB on the API side.

cvan commented 10 years ago

date approved/rejected/disabled/deleted (if we are viewing by status approved/rejected/disabled/deleted, but not rejected)

Should we be keeping track of the entire history of status changes, then? I would think we'd only need to show the date of the last status change event, but if we might need some kind of status history then it'd be worth taking that into account in how that data is stored in the DB on the API side.

In the Marketplace, we have three timestamps: date_created, date_modified, date_nominated (which is the date of approval/rejection). Those are the most important ones that we'll actually need. What are your thoughts?

aricha commented 10 years ago

That seems reasonable to me. The reason I ask is in case we want to show some kind of history of status changes or any other date-related data, we'd probably want to account for that on the API side early so that we record that data from the beginning.

aricha commented 10 years ago

So do we want to display any border around the icons? I assume the icons in the mocks just happen to be circular instead of using a circular border.

Also, is there anything in particular we want to show as a backup / placeholder icon?

cvan commented 10 years ago

the icons don't need a border or anything. they just happen to be circular.

cvan commented 10 years ago

an icon is required, so no.

aricha commented 10 years ago

Fixed by #144.