mozilla / galaxy

To infinity and beyond. The front-end UI.
BSD 3-Clause "New" or "Revised" License
9 stars 14 forks source link

Markdown Editor Implementation #168

Closed birkanu closed 10 years ago

birkanu commented 10 years ago

The markdown editor for the Game Description field is implemented with code highlighting.

birkanu commented 10 years ago

Currently looks like this:

84k4v

birkanu commented 10 years ago

r?

birkanu commented 10 years ago

@yangshun and I thought that this markdown-js library is not very good at parsing everything, so I will switch to a different one.

yangshun commented 10 years ago

:+1:

birkanu commented 10 years ago

Library changed now. I am using marked for markdown parsing and highlight.js for code block highlighting. It looks pretty good on the game submission page. But, the game details page's CSS needs to be modified a little to preview the rendered html properly.

birkanu commented 10 years ago

@cvan r?

cvan commented 10 years ago

we should make sure the punctuation is not hanging (try class .prose), so the bullets appear within the textarea.

cvan commented 10 years ago

r? @emoore24 @scottmeng can you help review this?

birkanu commented 10 years ago

we should make sure the punctuation is not hanging (try class .prose), so the bullets appear within the textarea.

@cvan bullets do appear within textarea.

birkanu commented 10 years ago

@yangshun Are you done with your changes here? It's ready to be merged on my side.

yangshun commented 10 years ago

yup done

yangshun commented 10 years ago

Ok @birkanu 's description markdown feature is ready for review. r? @cvan @scottmeng