search

mozilla / galaxy

To infinity and beyond. The front-end UI.
BSD 3-Clause "New" or "Revised" License
9 stars 14 forks source link

game status bug on curation page #178

Open scottmeng opened 10 years ago

scottmeng commented 10 years ago

quickcast

once disabled, an initially "pending" featured game will be re-enabled into "approved" status. Not sure if this is designed this way intentionally.

scottmeng commented 10 years ago

@cvan @emoore24 I am also thinking should a "deleted" or "disabled" game be featured in the first place. This is relevant to #175

emoore24 commented 10 years ago

Hmm maybe it might be better to remove a game from the featured list once it is disabled? Or even rip out the delete and disable buttons and leave that to the review page?

scottmeng commented 10 years ago

@emoore24 that is what I was thinking of as well. I am also working to make curation page more aligned in terms of styling with other dashboard pages (using font awesome icons and etc.)

emoore24 commented 10 years ago

Wait were you thinking of doing the former (keep the button but remove from the feature list on disable) or the latter (take out buttons entirely)? haha

Regardless of if the buttons stay or not I think we should have game be unfeatured when it is disabled (I'm not sure if that is happening now in the backend or not)

scottmeng commented 10 years ago

I was thinking of removing the buttons all together.

That sounds like a good idea. However, game status and featured games are totally irrelevant for now and I think there is some confusion regarding the flow how a game can be approved and featured.