Dev dashboard disable - Githubissues

mozilla / galaxy

To infinity and beyond. The front-end UI.

BSD 3-Clause "New" or "Revised" License

9 stars 14 forks source link

Dev dashboard disable #183

Closed CharlesChong closed 10 years ago

CharlesChong commented 10 years ago

See issue #99

Changes:

Deleted games don't show on load/deletion
Disabled games do not have the disable button
Table entries have proper html/css when games are disabled

Issues:

~~Queue position does not update when a game is deleted or disabled. Is there a way to reload the page builder? Or should I manually go through and get the queue positions?~~
I have hardcoded the gettext("Disabled") in developer_dashboard.js line#72 when it should really match the statusName filter from helpers.js. How would I call this function? I can't seem to figure that out.
Waiting time does not update when a game has been put out of pending and back into pending state. Blocked cvan/galaxy-api#194.

birkanu commented 10 years ago

Have you tried require('views').reload();? I guess this does not reload the builder though.

CharlesChong commented 10 years ago

so it turns out require('views').reload(); works to refresh queue position, but causes a page flicker. I'm going to use it for now though.

mattbasta commented 10 years ago

Bonus points if you can open the chrome dev tools to the Timeline tab and debug why there's a flicker.

CharlesChong commented 10 years ago

I'm not very good at using the Timeline tab, but from what I can tell, the .reload() requires an XHR load to game list to retrieve the new game queue positions, which takes some time in addition to rerendering the page.

mattbasta commented 10 years ago

Sounds like you need to lean on the caching framework, which you've turned off. Which sounds like a bad idea.

But that aside, this isn't something that's user-facing so it really doesn't matter.

CharlesChong commented 10 years ago

Would caching work? The main reason why I refresh the data is because a game disable or deletion can result in different queue positions, which I need to retrieve from the database.

mattbasta commented 10 years ago

In that case, the server should respond to the action with the updated queue position and you should then use that data to perform cache rewriting.

CharlesChong commented 10 years ago

I'm not sure how to do that. I'm going to merge this in for now.