search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

DENG-1267 - Handle geoip skip from metadata #2440

Closed relud closed 1 year ago

relud commented 1 year ago

blocks https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/777

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 93.50% and project coverage change: -1.13% :warning:

Comparison is base (6ac8977) 85.89% compared to head (fb82607) 84.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2440 +/- ## ============================================ - Coverage 85.89% 84.76% -1.13% - Complexity 874 885 +11 ============================================ Files 123 115 -8 Lines 5118 4734 -384 Branches 509 517 +8 ============================================ - Hits 4396 4013 -383 Misses 560 560 + Partials 162 161 -1 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.52% <93.50%> (+0.20%)` | :arrow_up: | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `75.07% <ø> (ø)` | | | [ingestion_edge](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `?` | | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `88.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [...n/java/com/mozilla/telemetry/IpPrivacyDecoder.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWJlYW0vc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvSXBQcml2YWN5RGVjb2Rlci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...y/ingestion/core/schema/PipelineMetadataStore.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWNvcmUvc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvaW5nZXN0aW9uL2NvcmUvc2NoZW1hL1BpcGVsaW5lTWV0YWRhdGFTdG9yZS5qYXZh) | `74.07% <ø> (ø)` | | | [...n/java/com/mozilla/telemetry/decoder/ParseUri.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWJlYW0vc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvZGVjb2Rlci9QYXJzZVVyaS5qYXZh) | `96.81% <92.85%> (+0.60%)` | :arrow_up: | | [...m/src/main/java/com/mozilla/telemetry/Decoder.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWJlYW0vc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvRGVjb2Rlci5qYXZh) | `89.13% <100.00%> (+0.24%)` | :arrow_up: | | [...java/com/mozilla/telemetry/decoder/ParseProxy.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWJlYW0vc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvZGVjb2Rlci9QYXJzZVByb3h5LmphdmE=) | `96.87% <100.00%> (+2.75%)` | :arrow_up: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2440/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.