search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

DENG-1802 Add match type to parameter for suggest pings #2500

Closed quiiver closed 10 months ago

quiiver commented 10 months ago

Adds match_type detail to the custom_data parameter. This is to support the Higher Placement experiment.

quiiver commented 10 months ago

cc @ncloudioj

quiiver commented 10 months ago

I will need to back-port this to @relud s change to support the ping centre migration in #2466

relud commented 10 months ago

I will need to back-port this to @relud s change to support the ping centre migration in #2466

I'll handle that if this is merged before mine

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e2e94e2) 85.40% compared to head (7f419b3) 84.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2500 +/- ## ============================================ - Coverage 85.40% 84.15% -1.25% - Complexity 901 907 +6 ============================================ Files 123 115 -8 Lines 5194 4778 -416 Branches 521 521 ============================================ - Hits 4436 4021 -415 - Misses 592 593 +1 + Partials 166 164 -2 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.96% <85.71%> (+0.06%)` | :arrow_up: | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `75.07% <ø> (ø)` | | | [ingestion_edge](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `?` | | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `84.88% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [...metry/contextualservices/SponsoredInteraction.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWJlYW0vc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvY29udGV4dHVhbHNlcnZpY2VzL1Nwb25zb3JlZEludGVyYWN0aW9uLmphdmE=) | `81.81% <ø> (ø)` | | | [...elemetry/contextualservices/ParseReportingUrl.java](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-aW5nZXN0aW9uLWJlYW0vc3JjL21haW4vamF2YS9jb20vbW96aWxsYS90ZWxlbWV0cnkvY29udGV4dHVhbHNlcnZpY2VzL1BhcnNlUmVwb3J0aW5nVXJsLmphdmE=) | `79.46% <85.71%> (-0.08%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2500/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.