search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Revert "Update Beam SDK to 2.51 (#2518)" #2519

Closed akkomar closed 9 months ago

akkomar commented 9 months ago

This reverts commit 1deae6d5eb8ad001ec13ba9aa7c042e7c16a3379.

See https://github.com/mozilla/gcp-ingestion/pull/2518#issuecomment-1828568403

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (93ffa80) 85.41% compared to head (92dc541) 85.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2519 +/- ## ========================================= Coverage 85.41% 85.41% Complexity 907 907 ========================================= Files 123 123 Lines 5205 5205 Branches 521 521 ========================================= Hits 4446 4446 Misses 593 593 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2519/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2519/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.92% <ø> (ø)` | | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2519/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `75.07% <ø> (ø)` | | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2519/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `84.88% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

whd commented 9 months ago

hopefully not needed since https://github.com/mozilla/gcp-ingestion/pull/2521 fixes the dependency issue