search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

As of beam 2.44 google-cloud-storage is no longer a test-only dependency #2521

Closed relud closed 9 months ago

relud commented 9 months ago

fixes https://github.com/mozilla/gcp-ingestion/pull/2518#issuecomment-1828448944

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (93ffa80) 85.41% compared to head (98571d7) 85.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2521 +/- ## ========================================= Coverage 85.41% 85.41% Complexity 907 907 ========================================= Files 123 123 Lines 5205 5205 Branches 521 521 ========================================= Hits 4446 4446 Misses 593 593 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2521/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.92% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akkomar commented 9 months ago

It might be better to import beam-sdks-java-extensions-google-cloud-platform-core as mentioned in v2.44.0 release notes.

relud commented 9 months ago

i tried adding that and it didn't have any impact, i don't mind adding it just to be thorough

whd commented 9 months ago

This appears to have done the trick, stage is running on 2.51.0 now.