search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Add support for new searchwith contextual services ping #2531

Closed mkaply closed 7 months ago

mkaply commented 8 months ago

We're adding a new contextual services ping and I think this is all that's required to support it.

Problem: We need to ingest an additional data source from Firefox and put it into the contextual service pipeline.

Solution: Add the new type (searchwith) to the existing lists and data based on the glean ping.

Acceptance criteria: New data is available to the beam,

It does appear there is a test here I didn't spot the first time. I'll see if I can update and run locally.

mkaply commented 8 months ago

Firefox code changes are here:

https://phabricator.services.mozilla.com/D196490

quiiver commented 7 months ago

Would also like to see updated test cases before merging. thanks!

mkaply commented 7 months ago

So looking at these tests, they seem to be for the old mechanism (the explicit quicksuggest-impression versus the new quick-suggest doctype).

Is there some straightforward way for me to run these tests if I modify them?

codecov-commenter commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b0aba7d) 85.28% compared to head (6154424) 78.94%. Report is 2 commits behind head on main.

:exclamation: Current head 6154424 differs from pull request most recent head e10077d. Consider uploading reports for the commit e10077d to get more accurate results

Files Patch % Lines
...elemetry/contextualservices/ParseReportingUrl.java 58.33% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2531 +/- ## ============================================ - Coverage 85.28% 78.94% -6.34% + Complexity 906 875 -31 ============================================ Files 123 123 Lines 5240 5244 +4 Branches 531 533 +2 ============================================ - Hits 4469 4140 -329 - Misses 599 947 +348 + Partials 172 157 -15 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2531/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `74.79% <58.33%> (-7.99%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mkaply commented 7 months ago

Test added.