Closed mkaply closed 7 months ago
Firefox code changes are here:
Would also like to see updated test cases before merging. thanks!
So looking at these tests, they seem to be for the old mechanism (the explicit quicksuggest-impression versus the new quick-suggest doctype).
Is there some straightforward way for me to run these tests if I modify them?
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
b0aba7d
) 85.28% compared to head (6154424
) 78.94%. Report is 2 commits behind head on main.:exclamation: Current head 6154424 differs from pull request most recent head e10077d. Consider uploading reports for the commit e10077d to get more accurate results
Files | Patch % | Lines |
---|---|---|
...elemetry/contextualservices/ParseReportingUrl.java | 58.33% | 3 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Test added.
We're adding a new contextual services ping and I think this is all that's required to support it.
Problem: We need to ingest an additional data source from Firefox and put it into the contextual service pipeline.
Solution: Add the new type (searchwith) to the existing lists and data based on the glean ping.
Acceptance criteria: New data is available to the beam,
It does appear there is a test here I didn't spot the first time. I'll see if I can update and run locally.