Closed cbguder closed 7 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
4b4839f
) 85.28% compared to head (cf6761a
) 74.78%.:exclamation: Current head cf6761a differs from pull request most recent head 577f8fe. Consider uploading reports for the commit 577f8fe to get more accurate results
Files | Patch % | Lines |
---|---|---|
...lla/telemetry/contextualservices/EmitCounters.java | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@quiiver Done!
The Glean migration collapsed the
contextual_services/topsites_impression_v1/valid_url
andcontextual_services/topsites_click_v1/valid_url
metrics that were used on this dashboard onto a singlefirefox_desktop/top_sites_v1/valid_url
metric.This introduces two new metrics:
firefox_desktop/top_sites/valid_click
andfirefox_desktop/top_sites/valid_impression
which we can use to fix the dashboard.JIRA: AE-155