search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Emit additional metrics for TopSites #2535

Closed cbguder closed 7 months ago

cbguder commented 7 months ago

The Glean migration collapsed the contextual_services/topsites_impression_v1/valid_url and contextual_services/topsites_click_v1/valid_url metrics that were used on this dashboard onto a single firefox_desktop/top_sites_v1/valid_url metric.

This introduces two new metrics: firefox_desktop/top_sites/valid_click and firefox_desktop/top_sites/valid_impression which we can use to fix the dashboard.

JIRA: AE-155

codecov-commenter commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4b4839f) 85.28% compared to head (cf6761a) 74.78%.

:exclamation: Current head cf6761a differs from pull request most recent head 577f8fe. Consider uploading reports for the commit 577f8fe to get more accurate results

Files Patch % Lines
...lla/telemetry/contextualservices/EmitCounters.java 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2535 +/- ## ============================================= - Coverage 85.28% 74.78% -10.51% + Complexity 906 776 -130 ============================================= Files 123 95 -28 Lines 5241 4164 -1077 Branches 531 485 -46 ============================================= - Hits 4470 3114 -1356 - Misses 599 908 +309 + Partials 172 142 -30 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2535/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2535/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `74.78% <0.00%> (-8.01%)` | :arrow_down: | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2535/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `?` | | | [ingestion_edge](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2535/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `?` | | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2535/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cbguder commented 7 months ago

@quiiver Done!