Closed nipunshukla21 closed 7 months ago
lgtm, r? @mozilla/data-platform-infra-wg as the current code owners
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b0aba7d
) 85.28% compared to head (59dd4ae
) 79.01%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@whd: can this be deployed to prod and @nipunshukla21 notified when it is done so that he can merge https://phabricator.services.mozilla.com/D198610
note: this depends on https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/801
@nipunshukla21 you should be good to merge https://phabricator.services.mozilla.com/D198610.
On the pipeline side we should have merged and deployed https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/801 before this PR, since we would want the schemas to be up to date and not create any potentially (temporarily) unrouteable messages. I would have caught this at deploy time via a casual inspection described on https://mozilla-hub.atlassian.net/wiki/spaces/SRE/pages/27922303/Ingestion+Beam#IngestionBeam-ProdCodeDeploymentPolicy but because we're doing some Pub/Sub Lite testing we deployed the code changes before the schemas changes.
Fortunately https://phabricator.services.mozilla.com/D198610 presumably was also gating submission of the new pings so we were unlikely to run into any issues with deployment order. I re-ran probe scraper to pick up the generated schemas changes and everything has landed as of 11:13 PT.
Added parsing for new stub installer telemetry which records partner distribution IDs and versions. Also updated stub installer URI to version 9 to accommodate for new telemetry fields.