search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Updated version number and arguments of Stub URI parser #2538

Closed nipunshukla21 closed 7 months ago

nipunshukla21 commented 7 months ago

Added parsing for new stub installer telemetry which records partner distribution IDs and versions. Also updated stub installer URI to version 9 to accommodate for new telemetry fields.

relud commented 7 months ago

lgtm, r? @mozilla/data-platform-infra-wg as the current code owners

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b0aba7d) 85.28% compared to head (59dd4ae) 79.01%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2538 +/- ## ============================================ - Coverage 85.28% 79.01% -6.28% + Complexity 906 875 -31 ============================================ Files 123 123 Lines 5240 5241 +1 Branches 531 531 ============================================ - Hits 4469 4141 -328 - Misses 599 944 +345 + Partials 172 156 -16 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2538/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `74.87% <100.00%> (-7.91%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relud commented 7 months ago

@whd: can this be deployed to prod and @nipunshukla21 notified when it is done so that he can merge https://phabricator.services.mozilla.com/D198610

note: this depends on https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/801

whd commented 7 months ago

@nipunshukla21 you should be good to merge https://phabricator.services.mozilla.com/D198610.

On the pipeline side we should have merged and deployed https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/801 before this PR, since we would want the schemas to be up to date and not create any potentially (temporarily) unrouteable messages. I would have caught this at deploy time via a casual inspection described on https://mozilla-hub.atlassian.net/wiki/spaces/SRE/pages/27922303/Ingestion+Beam#IngestionBeam-ProdCodeDeploymentPolicy but because we're doing some Pub/Sub Lite testing we deployed the code changes before the schemas changes.

Fortunately https://phabricator.services.mozilla.com/D198610 presumably was also gating submission of the new pings so we were unlikely to run into any issues with deployment order. I re-ran probe scraper to pick up the generated schemas changes and everything has landed as of 11:13 PT.