mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Add support for mobile suggest pings #2562

Closed cbguder closed 5 months ago

cbguder commented 5 months ago

Adds support for mobile suggest pings in ParseReportingUrl

Also:

quiiver commented 5 months ago

@whd What do we need to get @mozilla/ads-engineering write access to the repository?

whd commented 5 months ago

@whd What do we need to get @mozilla/ads-engineering write access to the repository?

I don't think there are any specific considerations here, so any repo admin can add that team to collaborators. I'd recommend adding CODEOWNERS with either @mozilla/data-platform-infra-wg or @mozilla/telemetry as the default if you're adding more teams with write access.

quiiver commented 5 months ago

Once the job has been tested we can merge and alert whd to the change landing so that it can be deployed.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 85.10638% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 79.02%. Comparing base (4fc6456) to head (05a90e6).

Files Patch % Lines
...elemetry/contextualservices/ParseReportingUrl.java 85.10% 8 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2562 +/- ## ============================================ - Coverage 85.19% 79.02% -6.18% + Complexity 911 888 -23 ============================================ Files 123 123 Lines 5256 5263 +7 Branches 536 529 -7 ============================================ - Hits 4478 4159 -319 - Misses 607 951 +344 + Partials 171 153 -18 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2562/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `74.91% <85.10%> (-7.77%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.