mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Fix namespace types for Mobile Suggest #2566

Closed cbguder closed 5 months ago

cbguder commented 5 months ago

Turns out the pipeline code also had these wrong. Fixed to support actual mobile namespaces (org-mozilla-fenix, org-mozilla-ios-fennec, etc.).

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (feaf7ff) to head (81e992f).

Files Patch % Lines
...elemetry/contextualservices/ParseReportingUrl.java 81.25% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2566 +/- ## ============================================ + Coverage 85.31% 85.32% +0.01% + Complexity 940 919 -21 ============================================ Files 123 123 Lines 5263 5262 -1 Branches 529 529 ============================================ Hits 4490 4490 Misses 606 606 + Partials 167 166 -1 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2566/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2566/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.84% <81.25%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.