search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 32 forks source link

Fix handling of duplicate normalized field names in sink #2610

Closed akkomar closed 1 month ago

akkomar commented 3 months ago

Fixes the issue with map fields reported in https://github.com/mozilla/gcp-ingestion/issues/2609

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.02%. Comparing base (0a5ef4a) to head (6b9ff47).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2610 +/- ## ========================================= Coverage 85.01% 85.02% Complexity 906 906 ========================================= Files 123 123 Lines 5267 5268 +1 Branches 525 526 +1 ========================================= + Hits 4478 4479 +1 Misses 620 620 Partials 169 169 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2610/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.44% <100.00%> (+<0.01%)` | :arrow_up: | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `73.64% <100.00%> (+0.03%)` | :arrow_up: | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `84.07% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.