search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

AE-443 Updated quick-suggest clickURL required params. #2611

Closed gleonard-m closed 3 weeks ago

gleonard-m commented 3 weeks ago

The json file update for sponsored suggest on 2024-06-21 included changes to the non-Amazon click Urls (the new version does not include sub2, includes ctaid).

Current Structure

https://mozillacla.ampxdirect.com/chewy?sub1=chewy&sub2=us&custom-data=1220&ctag=319093355us1220%YYYYMMDDHH%

New Structure

https://mozillacla.ampxdirect.com/?partner=firefox_cla&sub1=IS_US&ctaid=74319&source=als_tiles&custom-data=1220&ctag=319154513us1220%YYYYMMDDHH%

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.38%. Comparing base (e1b318c) to head (d4c9f7a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2611 +/- ## ============================================ + Coverage 85.35% 85.38% +0.02% - Complexity 919 921 +2 ============================================ Files 123 123 Lines 5273 5283 +10 Branches 529 530 +1 ============================================ + Hits 4501 4511 +10 Misses 606 606 Partials 166 166 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2611/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2611/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.91% <100.00%> (+0.04%)` | :arrow_up: | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2611/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `75.07% <ø> (ø)` | | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2611/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `84.92% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.