search

mozilla / gcp-ingestion

Documentation and implementation of telemetry ingestion on Google Cloud Platform
https://mozilla.github.io/gcp-ingestion/
Mozilla Public License 2.0
75 stars 31 forks source link

Fix boolean to float coercion in ingestion sink #2627

Closed akkomar closed 3 weeks ago

akkomar commented 1 month ago

In https://github.com/mozilla/gcp-ingestion/issues/2609#issuecomment-2291014904 we discovered that we're not coercing booleans to floats in FLOAT fields. This PR fixes this issue.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (35b03c2) to head (0789a25). Report is 1 commits behind head on main.

Files Patch % Lines
...tion/core/transform/PubsubMessageToObjectNode.java 17.64% 10 Missing and 4 partials :warning:
.../telemetry/transforms/PubsubMessageToTableRow.java 33.33% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2627 +/- ## ============================================ - Coverage 85.25% 85.01% -0.24% Complexity 906 906 ============================================ Files 123 123 Lines 5244 5267 +23 Branches 520 525 +5 ============================================ + Hits 4471 4478 +7 - Misses 606 620 +14 - Partials 167 169 +2 ``` | [Flag](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2627/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [ingestion_beam](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2627/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `82.44% <21.73%> (-0.29%)` | :arrow_down: | | [ingestion_core](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2627/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `73.60% <17.64%> (-1.48%)` | :arrow_down: | | [ingestion_sink](https://app.codecov.io/gh/mozilla/gcp-ingestion/pull/2627/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `84.06% <17.64%> (-0.87%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.