mozilla / geckodriver

WebDriver for Firefox
https://firefox-source-docs.mozilla.org/testing/geckodriver/
Mozilla Public License 2.0
7.03k stars 1.51k forks source link

Geckodriver 0.32.0 can no longer locate system wide Firefox installation on Windows? #2053

Closed ngladitz closed 1 year ago

ngladitz commented 1 year ago

System

Testcase

I tried to update geckodriver from 0.31.0 to 0.32.0. With the update geckodriver can no longer locate the system wide Firefox installation.

Trace-level log

1665739034407   geckodriver INFO    Listening on 127.0.0.1:58734
1665739034434   webdriver::server   DEBUG   -> GET /status 
1665739034434   webdriver::server   DEBUG   <- 200 OK {"value":{"message":"","ready":true}}
1665739034439   webdriver::server   DEBUG   -> POST /session {"capabilities":{"firstMatch":[{}],"alwaysMatch":{"browserName":"firefox","moz:firefoxOptions":{"prefs":{"devtools.console.stdout.content":true}}}}}
1665739034443   webdriver::server   DEBUG   <- 500 Internal Server Error {"value":{"error":"session not created","message":"Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line","stacktrace":""}}
AlexHendriks commented 1 year ago

The win64 version is missing in: https://api.github.com/repos/mozilla/geckodriver/releases and https://github.com/mozilla/geckodriver/releases

Although it can be manually downloaded via https://github.com/mozilla/geckodriver/releases/download/v0.32.0/geckodriver-v0.32.0-win64.zip

moritz2k commented 1 year ago

@AlexHendriks The win64 is just hidden on that page, click on "show all assets" at the bottom.

AlexHendriks commented 1 year ago

you are correct @moritz2k

ngladitz commented 1 year ago

Ah thanks I didn't realize that I might have replaced a 64-bit 0.31.0 with a 32-bit 0.32.0. If the 32-bit version indeed does not locate a 64-bit Firefox installation that is likely what I ran into here.

whimboo commented 1 year ago

@ngladitz so the 64bit geckodriver binary works fine with the default installation of Firefox? I'm fairly sure that this was the problem given that we haven't changed anything for the detection code on Windows.

ngladitz commented 1 year ago

@whimboo yes thank you I've just confirmed that switching to the 64-bit build fixes the issue for me.