mozilla / geckodriver

WebDriver for Firefox
https://firefox-source-docs.mozilla.org/testing/geckodriver/
Mozilla Public License 2.0
7.03k stars 1.51k forks source link

Missing Socket Responses #2091

Open titusfortner opened 1 year ago

titusfortner commented 1 year ago

We're seeing this in the Selenium CI in all bindings and all versions of Firefox; starting on dates that coincide with 0.32.2 release. I tried to dive into the responses with Ruby.

Here are logs with 0.32.0 and 0.32.2. I don't see any difference in what is getting logged by geckodriver/marionette, but you can see that Ruby is just not getting any socket responses.

whimboo commented 1 year ago

Thanks for filing the bug Titus! Just some questions:

I assume that the problem you are describing here is around the navigation events that are not visible in the 0.32.2 logs?

whimboo commented 1 year ago

Probably the issue here is related to the following prefs which aren't set:

1676992989489   CDP ERROR   Invalid browser preferences for CDP. Set "fission.webContentIsolationStrategy"to 0 and "fission.bfcacheInParent" to false before Firefox starts.

Note that we only want to see those set for CDP usage but they should not be set for BiDi! Probably this is causing the problem.

@titusfortner is there any reason why the Ruby binding is using the navigation events from CDP? If not could the code be changed to get rid of CDP and use BiDi?