mozilla / geckodriver

WebDriver for Firefox
https://firefox-source-docs.mozilla.org/testing/geckodriver/
Mozilla Public License 2.0
7.03k stars 1.51k forks source link

Update broken link in README #2148

Open shailshouryya opened 6 months ago

shailshouryya commented 6 months ago

The https://github.com/mozilla/geckodriver/blob/79cef6e77f250228e4463d3dedac54b9d9369c17/README.md?plain=1#L34

link under the Documentation section from the README points to https://seleniumhq.github.io/docs/, which redirects to https://www.selenium.dev/docs/, which is currently a 404. However, https://www.selenium.dev/documentation/ does work, so I think README.md should be updated to

--- a/README.md
+++ b/README.md

@@ -33, +33

- [Selenium](https://seleniumhq.github.io/docs/) (work in progress)
+ [Selenium](https://www.selenium.dev/documentation/) (work in progress)
  * [C# API](https://seleniumhq.github.io/selenium/docs/api/dotnet/)

I also noticed the base domain seleniumhq.github.io redirects to www.selenium.dev - so should all other https://seleniumhq.github.io/RESOURCE links be updated to https://www.selenium.dev/RESOURCE as well?

I can also make a pull request here, but looking at this comment from a recent pull request, I'm not sure if that change would go here (on GitHub), or somewhere else?

whimboo commented 6 months ago

Thank you @shailshouryya! We might certainly update the readme regarding your proposals. If you want to make a contribution you are welcome and I can help to guide you through the process.

As you noticed we do not accept PRs on the GitHub repository because it's not the canonical one. Documentation in how to get started you can find at https://firefox-source-docs.mozilla.org/testing/geckodriver/index.html. Feel free to also join our Matrix channel for a direct communication. Thanks in advance!

whimboo commented 1 month ago

For now I've added a working item for our next 0.35.0 release of geckodriver: https://bugzilla.mozilla.org/show_bug.cgi?id=1871543