search

mozilla / grcov

Rust tool to collect and aggregate code coverage data for multiple source files
Mozilla Public License 2.0
1.17k stars 148 forks source link

Add argument to sort output types #1078

Closed zax-xyz closed 10 months ago

zax-xyz commented 1 year ago

Adds optional argument to specify a list of output types to sort files for. Sorts final results lexicographically by filepath for relevant types. Defaults to only markdown, as this format is intended to be human readable

Resolves #1057

calixteman commented 1 year ago

I'm not super excited by the idea to waste whatever time for sorting the filepath. But I'm fine to have an option which could be true by default for some output formats and false for the others. So from my pov, this PR is a no-go in the current state.

zax-xyz commented 1 year ago

I'm not super excited by the idea to waste whatever time for sorting the filepath.

That's a very good point, forgot to mention that as a concern. An option sounds like a good idea

marco-c commented 1 year ago

@zaxutic are you planning on finishing this up?

zax-xyz commented 1 year ago

@zaxutic are you planning on finishing this up?

sorry yeah @marco-c, I've been a bit busy and got pretty sick recently, but I should be free to finish this off soon

zax-xyz commented 1 year ago

Apologies for the delay, got back around to this with an option that defaults to markdown, and updated the PR description to reflect it. Not sure if the help description is sufficient or if the argument should be in a different position within Opt

tirumaraiselvan commented 11 months ago

Would be great to see this merged!