mozilla / grcov

Rust tool to collect and aggregate code coverage data for multiple source files
Mozilla Public License 2.0
1.16k stars 148 forks source link

Benchmarks are broken #1127

Closed zamazan4ik closed 10 months ago

zamazan4ik commented 10 months ago

On the latest commit in the master branch during the cargo +nightly bench execution I get the following error:

<some logs are omitted>

Compiling grcov v0.8.19 (/home/zamazan4ik/open_source/grcov)
error[E0061]: this function takes 3 arguments but 2 arguments were supplied
   --> benches/output.rs:63:19
    |
63  |           black_box(output_covdir(
    |  ___________________^^^^^^^^^^^^^-
64  | |             &generate_cov_result_iter(),
65  | |             Some(&dir.path().join("temp")),
66  | |         ));
    | |_________- an argument of type `usize` is missing
    |
note: function defined here
   --> /home/zamazan4ik/open_source/grcov/src/output.rs:184:8
    |
184 | pub fn output_covdir(results: &[ResultTuple], output_file: Option<&Path>, precision: usize) {
    |        ^^^^^^^^^^^^^
help: provide the argument
    |
63  |         black_box(output_covdir(&generate_cov_result_iter(), Some(&dir.path().join("temp")), /* usize */));
    |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

For more information about this error, try `rustc --explain E0061`.
error: could not compile `grcov` (bench "output") due to previous error
warning: build failed, waiting for other jobs to finish...

Seems like the function interface was changed without fixing the corresponding benchmarks.