search

mozilla / gud

Mozilla Growth & Usage Dashboard, pronounced "Good"
https://gud.telemetry.mozilla.org
4 stars 4 forks source link

Fix #32: Refactor state management #48

Closed openjck closed 4 years ago

openjck commented 4 years ago

Updated :smiley:

hamilton commented 4 years ago

Rad – this works much better now, thanks @openjck. I am noticing that if I select "All Firefox Activity", the lowest date is set as I'd expect, but if I select "All Fenix Activity", the earliest date doesn't get set based on the new data (though the date element gives the "invalid date" red border). Mind taking a look at that?

openjck commented 4 years ago

Updated. Another good catch. Thank you!

jklukas commented 4 years ago

I'm taking a look and so far I've noticed very little change, which is great. I do like that the start and end dates get auto-populated per usage criterion with this change.

One small issue I've noticed is that the y axis boundaries are chosen differently in some cases. For example this DAU view has a max of 800k in stage, filling up the plot. But running this branch locally, the max is 2M, so everything is in the bottom third. WAU shows this to a lesser extent, and then boundaries are identical for MAU.

hamilton commented 4 years ago

great point @jklukas - thanks for checking. That's because the y axis extents are determined now by looking at the largest mau / wau / dau. We should probably have it so that if a metric is selected you only get that particular metric's extent. @openjck does that make sense? Should be easy to fix.

openjck commented 4 years ago

Hey, thanks @jklukas! Pushed up a commit which fixes that.

openjck commented 4 years ago

Thank you for the guidance and pair programming. It goes without saying that this wouldn't have gotten far without you.

openjck commented 4 years ago

🙌