search

mozilla / gud

Mozilla Growth & Usage Dashboard, pronounced "Good"
https://gud.telemetry.mozilla.org
3 stars 4 forks source link

Replace "FirefoxConnect" string with "Firefox for Echo Show" #84

Closed tdsmith closed 4 years ago

tdsmith commented 4 years ago

FirefoxConnect is listed as one of the products; Roland asked me what FirefoxConnect was and I had to do a Github code search to find out. :)

@hamilton

jklukas commented 4 years ago

@tdsmith It's also my understanding that FirefoxConnect is associated with Echo Show, but do we have confirmation it's not used for anything else? Can you link me the reference you have for this?

tdsmith commented 4 years ago

Only that it's the only mozilla-mobile repo that contains that string: https://github.com/search?q=org%3Amozilla-mobile+FirefoxConnect&type=Code

@liuche Does a claim that FirefoxConnect is exactly Firefox for Echo Show sound right to you?

liuche commented 4 years ago

Yes! Firefox Connect was the codename for Firefox Echo Show before the device was announced publicly. We can definitely switch those over.

jklukas commented 4 years ago

Thanks @liuche. I will go ahead and PR the frontend change to display "Firefox for Echo Show".