search

mozilla / gud

Mozilla Growth & Usage Dashboard, pronounced "Good"
https://gud.telemetry.mozilla.org
3 stars 4 forks source link

The brushing functionality needs substantially better guardrails #99

Closed hamilton closed 3 years ago

hamilton commented 4 years ago

The brushing functionality doesn't really have good guardrails, so things get out of hand pretty quickly.

  1. the brushing does not abide by the plot bounds
  2. short date ranges (like a single click) causes the whole thing to break.

Brushing out of range will pretty much break the app in weird ways, so we should be guarding against that.

A PR that fixes this will ensure:

a. date ranges that are < 1 day should not cause a state update. b. by default, brushing should never be able to pass the x extents.