search

mozilla / high-fidelity

HTML5 podcast app (for the Web, including FirefoxOS)
https://marketplace.firefox.com/app/podcasts
108 stars 40 forks source link

The search overlay doesn't cover the whole section #51

Closed mnoorenberghe closed 10 years ago

mnoorenberghe commented 10 years ago

search overlay

I fiddled with the CSS for a bit but couldn't easily make this work with CSS changes alone. I also think that overlaying the text box and search button isn't a good UX since it doesn't allow the user to refine their search before the search finishes.

tofumatt commented 10 years ago

Yeah, I've been meaning to fix this, thanks for pointing it out. I would also like to add a "cancel" option for the search, but you're right and maybe overlaying it is a bad idea to start with. Thanks for the feedback!

mnoorenberghe commented 10 years ago

I'm working on a pull request now that would move the spinner to be near the results and allow cancelling a previous XHR if a new search happens. Is that something you would consider?

tofumatt commented 10 years ago

Sweet, thanks!