search

mozilla / high-fidelity

HTML5 podcast app (for the Web, including FirefoxOS)
https://marketplace.firefox.com/app/podcasts
108 stars 40 forks source link

Updating ember-cli to 1.13.13. Modifying CSP rules to match applicati… #92

Open jonathanKingston opened 8 years ago

jonathanKingston commented 8 years ago

…on usage. Fixes #78, #77

@brittanystoroz as mentioned let me know if this is an issue.

Thanks!

jonathanKingston commented 8 years ago

Working on fixing those tests, I thought it was just a timeout etc.

jonathanKingston commented 8 years ago

@brittanystoroz tests now passing.

I removed tests that were not being used besides one: tests/unit/components/audio-player-test.js The dependency injection doesn't seem to work with the init function whilst testing, I spent all day looking into combinations of ways round this - I have a feeling this will be fixed in ^2.0.0 ember which has stubbing of services: https://guides.emberjs.com/v2.0.0/testing/testing-components/#toc_stubbing-services.

Please let me know if there is any issues with this; thank you!

brittanydionigi commented 8 years ago

@jonathanKingston Hey sorry for the slow reply -- I'm not 100% maintaining this app any more, it was passed off to some other team members a while back. I'll check up with them on what kind of continued work is planned and see who might be a better contact for you in the future. Regardless, I'll try to look at this PR before the end of the week and give feedback. Thanks for contributing!

jonathanKingston commented 8 years ago

@brittanystoroz thanks! I wasn't expecting a quick reply because of the holidays etc :D. I was mostly just interested in Mozilla's use of Ember are there any other interesting ones I can look at also?