mozilla / high-fidelity

HTML5 podcast app (for the Web, including FirefoxOS)
https://marketplace.firefox.com/app/podcasts
108 stars 40 forks source link

Get Ember bugfix for major jQuery assertion error #93

Closed kriscooke closed 8 years ago

kriscooke commented 8 years ago

Newcomers doing bower install currently resolve to jQuery 1.12; in emberjs/ember.js there is a silly jQuery detection assert error right in the framework loading sequence, resulting in a major fail as Ember cannot finish loading.

Without the bugfix, Ember apps with jQuery > 1.11 fail without even being able to load their app. Indeed, I couldn't even run the tests on master. This results in a confusing error message, since 1.12 should be just fine (and of course it is):

Uncaught Error: Assertion Failed: Ember Views require jQuery between 1.7 and 2.1

This is fixed by updating to emberjs/ember.js v1.13.13.

tofumatt commented 8 years ago

Cool, thanks for the detailed explanation and the patch!

fwenzel commented 8 years ago

Thanks Kris!