search

mozilla / id.webmaker.org

OAuth 2.0 identity provider for Webmaker
https://id.webmaker.org
Mozilla Public License 2.0
19 stars 51 forks source link

Remove Webmaker logo from Teach site login pages #407

Open mmmavis opened 8 years ago

mmmavis commented 8 years ago

Re: https://github.com/mozilla/teach.mozilla.org/issues/1383#issuecomment-169686824

Can we conditionally hide Webmaker logo based on client_id? If so let's hide the logo if the redirect comes from teach-api (both production wm_id_YX9X9DqK4d4fB9LuFbZy and staging wm_id_1H9nvpGGTQ4CkXGVn56p).

d(`･∀･)b

Pomax commented 8 years ago

Do we have a URL that shows off the wrong view right now?

@cade do we have anything in place that allows apps to register their own logo/branding? If so we might be able to use that instead.

cade commented 8 years ago

I’m pretty sure we can hotlink a logo within an iframe, right @cadecairos?

cadecairos commented 8 years ago

looool

cadecairos commented 8 years ago

@Pomax no, the Oauth provider doesn't have branding related fields for oauth clients

Pomax commented 8 years ago

thanks @cade! also if we ever meet, that's at least three beverages of choice I owe you.

mmmavis commented 8 years ago

This happened to me a few times when I tried to tag Simon on Github. i.e.,"at wex" vs @simonwex :wink: :smile:

cade commented 8 years ago

o

Let’s do this. :beers: :maple_leaf:

Pomax commented 8 years ago

damnit, I am on the wrong side of Canada =_= (well, the great side, but not the right one for beers and poutine)