Add pre-install script to copy env before install

[ryanwarsaw]

This verifies that the .env file has been copied before trying to run the post-install script.

[ryanwarsaw]

cc: @gideonthomas @cadecairos R+?

[Pomax]

R+ on my side

[gideonthomas]

I'm pretty sure the pre-install script is run on heroku as well. Won't this then use what's in sample.env over what's in the actual env?

[Pomax]

Good point! Easy enough to fix though: this is a node script, so we can simply add an if (process.env.NODE_ENV === "production") process.exit(0);

[ryanwarsaw]

@Pomax @gideonthomas Thanks for catching that, i went ahead and made the review changes requested, and learned a lot about Node's process API and environment-related stuff 👀 R+?

I also wanted to pick your brains on a question related to styling and JS, I'm used to working with languages like Java where there are several prominent standards (Google & Oracle's guides). However, with JS it seems to be much more diverse and spread out across the board. Is there a prominent standard with JS, or is it one of those things where as long as it passes lint it's okay?

🤔 💭

[ryanwarsaw]

I just realized I have to check for staging as well, I'm going to do it in the morning since it's 1 AM and I can't think straight. 😴

[Pomax]

@ryanwarsaw you can just check for a NODE_ENV var at all. If there is one, don't do anything, because whoever has that set clearly has special intentions.

[ryanwarsaw]

@Pomax R+?

[ryanwarsaw]

@Pomax R+? Thanks for the reviews.

[Pomax]

yup R+