search

mozilla / id.webmaker.org

OAuth 2.0 identity provider for Webmaker
https://id.webmaker.org
Mozilla Public License 2.0
18 stars 51 forks source link

Node 6 update #438

Closed Pomax closed 7 years ago

alanmoo commented 7 years ago

Given that Travis failed, does this repo need update to work with Node 6?

cadecairos commented 7 years ago

If i recall correctly this is a bug in eslint that we can fix with a flag.... I think I saw @gideonthomas fix it before somewhere.

gideonthomas commented 7 years ago

lol really? uhhhh, maybe it's in a closed pr, let me check.

cadecairos commented 7 years ago

lol really? uhhhh, maybe it's in a closed pr, let me check.

I'm not sure if it was in this repo or not... don't you remember fixing some rando error about leaking somthing-or-other?

cadecairos commented 7 years ago

maybe in publish?

Pomax commented 7 years ago

@cadecairos @gideonthomas fixed the issue by bumping lab - R?