search

mozilla / id.webmaker.org

OAuth 2.0 identity provider for Webmaker
https://id.webmaker.org
Mozilla Public License 2.0
18 stars 51 forks source link

added favicon #442

Closed kritisingh1 closed 6 years ago

kritisingh1 commented 6 years ago

favicon is added to the signup page of id.webmaker.org. PR #442 . Let me know if any changes are required. This is in reference to the issue opened by @flukeout as #434

flukeout commented 6 years ago

Cool, thanks for submitting! A few comments...

Can use the favicon that is currently being used on the mozilla website

Also, let's remove the changes to the package.json file. We are including the icon explicitly in the pages anyway, so I don't think we need to rely on that. Thanks!

kritisingh1 commented 6 years ago

@flukeout I have made the required the changes. Can you please review and merge my PR now? Thanks a lot.

On Tue, Sep 12, 2017 at 5:05 AM, Luke Pacholski notifications@github.com wrote:

Cool, thanks for submitting! A few comments...

Can use the favicon that is currently being used on the mozilla website https://www.mozilla.org/en-US/

Also, let's remove the changes to the package.json file. We are including the icon explicitly in the pages anyway, so I don't think we need to rely on that. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/id.webmaker.org/pull/442#issuecomment-328688181, or mute the thread https://github.com/notifications/unsubscribe-auth/AU_Bvo75vcT_02m_hlB4v39bFJbij3HNks5shcPEgaJpZM4PSArC .

flukeout commented 6 years ago

Hi @kritisingh1 - testing locally now, thanks!

flukeout commented 6 years ago

Great work @kritisingh1 - tested locally and the favicon shows up as expected.

kritisingh1 commented 6 years ago

Thanks @flukeout