install management - Githubissues

meandavejustice commented 9 years ago

Lots of changes in this pull request.

Would like to get some eyes on this @6a68 @lmorchard @nchapman @pdehaan

check-updates pulls our update metadata from package.json and will send an array of updates to the webpage.
update-approve sends up an array of addons to install
a series of events(documented in README) are sent from the addon to track status of addon installs.

Also have a couple extra events for further insight into the actual idea-town addon. ie: enabled, installed etc..

jaredhirsch commented 9 years ago

Running the addon locally now :-)

jaredhirsch commented 9 years ago

Alright, this looks great @meandavejustice! Recapping my feedback:

fix the little nitpicky things
use simple-prefs for the prefs you care about in package.json
file a followup bug to fetch the addon list from the server

After that, merge away, and we'll discuss v2 of the addon-front end API tomorrow

meandavejustice commented 9 years ago

@pdehaan These are the errors which seem to be wrong/not reasonable for this specific project..

[1] meandave@mainframe-x250> node_modules/eslint/bin/eslint.js *.js                                                                                                                     ~/moz-code/idea-town-addon

bootstrap.js
   4:1   error  Strict mode is not permitted         strict
   5:7   error  comp is defined but never used       no-unused-vars
  11:9   error  startup is defined but never used    no-unused-vars
  11:18  error  shutdown is defined but never used   no-unused-vars
  11:28  error  install is defined but never used    no-unused-vars
  11:37  error  uninstall is defined but never used  no-unused-vars

index.js
   15:5   error    `state` is never modified, use `const` instead                                                 prefer-const
   15:35  warning  Missing function expression name                                                               func-names
   23:13  error    setupWorker was used before it was defined                                                     no-use-before-define
   26:5   error    `button` is never modified, use `const` instead                                                prefer-const
   26:22  error    A function with a name starting with an uppercase letter should only be used as a constructor  new-cap
   36:12  warning  Missing function expression name                                                               func-names
   71:39  warning  Missing function expression name                                                               func-names
   77:7   error    `filteredUpdates` is never modified, use `const` instead                                       prefer-const
   78:27  warning  Missing function expression name                                                               func-names
   79:39  warning  Missing function expression name                                                               func-names
   88:42  warning  Missing function expression name                                                               func-names
  102:36  warning  Missing function expression name                                                               func-names
  123:21  warning  Missing function expression name                                                               func-names
  126:22  warning  Missing function expression name                                                               func-names
  129:23  warning  Missing function expression name                                                               func-names
  132:19  warning  Missing function expression name                                                               func-names
  135:25  warning  Missing function expression name                                                               func-names
  138:24  warning  Missing function expression name                                                               func-names
  141:25  warning  Missing function expression name                                                               func-names
  144:22  warning  Missing function expression name                                                               func-names
  147:26  warning  Missing function expression name                                                               func-names
  150:23  warning  Missing function expression name                                                               func-names

✖ 28 problems (11 errors, 17 warnings)

pdehaan commented 9 years ago

Re: ESLint errors in https://github.com/mozilla/idea-town-addon/pull/10#issuecomment-135500640,

It sounds from IRC that /bootstrap.js is auto-generated from jpm so we can add that file to .eslintignore.

And for the setupWorker was used before it was defined, it looks like we can fix that by adding "nofunc" to the no-use-before-define rule. Not sure why Airbnb doesn't specify that in their config, but it should be easy enough for us to override since functions get hoisted.

"no-use-before-define": [2, "nofunc"]

GitCop commented 9 years ago

There were the following issues with your Pull Request

Commit: 85e3a87639f51efb7374e899bf92057b242880a8
- Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/mozilla/idea-town-addon

This message was auto-generated by https://gitcop.com

GitCop commented 9 years ago

There were the following issues with your Pull Request

Commit: 065a3b9cd829e55d9e96cda75ed883be4203cbc2
- Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/mozilla/idea-town-addon

This message was auto-generated by https://gitcop.com

mozilla / idea-town-addon

install management #10