search

mozilla / idea-town-app

dom twiddling for the town of ideas
Mozilla Public License 2.0
0 stars 4 forks source link

chore(cleanup): Refactored the package.json file #16

Closed pdehaan closed 9 years ago

pdehaan commented 9 years ago

r? @6a68

pdehaan commented 9 years ago

Doesn't look like we enabled Travis CI for this repo yet, so I just enabled it and hopefully it will pick up the next PR.

meandavejustice commented 9 years ago

@pdehaan Can't we use extends: airbnb/base in order to get rid of the babel-eslint dep?

meandavejustice commented 9 years ago

@pdehaan globby and browserify could probably be moved into dev-deps as well

pdehaan commented 9 years ago

@meandavejustice "Can't we use extends: airbnb/base in order to get rid of the babel-eslint dep?"

Nope. Using airbnb/base only removes the eslint-plugin-react dependency (per https://github.com/airbnb/javascript/tree/master/packages/eslint-config-airbnb#usage).

pdehaan commented 9 years ago

globby and browserify could probably be moved into dev-deps as well

Possibly, both of those are only used by the scripts task, which means that if you only installed dependencies (but not devDeps) then you wouldn't be able to run scripts or the build task.

I guess it mostly depends on how @mostlygeek is planning on deploying this and if he wants any of the dependencies or if we're just deploying static files.

meandavejustice commented 9 years ago

@pdehaan I opened up a separate issue for discussing the static file dist. https://github.com/mozilla/idea-town-app/issues/17 You can disregard my comments here. lgtm :+1:

jaredhirsch commented 9 years ago

@pdehaan Awesome, testing now.

We're going to start issuing PRs from individual forks, rather than the parent repo, to put us on equal footing with contributors. (This is something that should be documented on the main idea-town repo, I think, since it'll hold true across all the sub-repos.) Not a big deal for this PR, but something to keep in mind for the next one :-)

jaredhirsch commented 9 years ago

Everything seems to be working. Thanks a lot for this patch, @pdehaan :beers: